-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update bash grammar to latest tree-sitter-bash rev #10526
feat: update bash grammar to latest tree-sitter-bash rev #10526
Conversation
@archseer I have reverted the changes as per your comments, and have deleted the (expansion_flags) line. I tested and the highlighting appears to work as expected without regression. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our queries really can use some work for bash too but that can be done seperatly. Thus doesn't regress anything and fixes a lot of bugs
The upstream queries basically seem unmaimtaimed but the nvim queries are a lot more expensive than ours.
This PR addresses #3151
I have set the rev for the bash grammar to the latest commit hash on master for tree-sitter-bash, and have updated the runtime/queries/bash/highlights.scm to the latest for the updated grammar as well.