Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update bash grammar to latest tree-sitter-bash rev #10526

Merged

Conversation

CSergienko
Copy link
Contributor

This PR addresses #3151

image

I have set the rev for the bash grammar to the latest commit hash on master for tree-sitter-bash, and have updated the runtime/queries/bash/highlights.scm to the latest for the updated grammar as well.

@CSergienko
Copy link
Contributor Author

@archseer I have reverted the changes as per your comments, and have deleted the (expansion_flags) line.

I tested and the highlighting appears to work as expected without regression.

Copy link
Member

@pascalkuthe pascalkuthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our queries really can use some work for bash too but that can be done seperatly. Thus doesn't regress anything and fixes a lot of bugs

The upstream queries basically seem unmaimtaimed but the nvim queries are a lot more expensive than ours.

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. A-language-support Area: Support for programming/text languages labels Apr 20, 2024
@the-mikedavis the-mikedavis merged commit 345e687 into helix-editor:master Apr 20, 2024
6 checks passed
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
@CSergienko CSergienko deleted the feature/update-bash-grammar-rev branch April 21, 2024 08:22
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
Chirikumbrah pushed a commit to Chirikumbrah/helix that referenced this pull request Jun 15, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants